Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add './' if the path already starts with '../' #47

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Don't add './' if the path already starts with '../' #47

merged 1 commit into from
Nov 3, 2017

Conversation

robindijkhof
Copy link
Contributor

'./../something' is the same as '../something'

@robindijkhof
Don't add './' if the path already starts with '../'
fe32277 
'./../something' is the same as '../something'
@SamVerschueren
Copy link

This PR fixes #37. Any chance of adding or reviewing this change?

@soates I totally understand if you have a busy life and don't have time looking into maintaining this (right now). Think about adding someone as a co-maintainer of the repository to share ownership so that the extensions benefits from it with new improvements and fixes (like this one).

@Lindsor
Copy link

Lindsor commented Aug 1, 2017

Any update on this? Id like this in as well

@thomaswmanion
Copy link

Think the dude raged quit GitHub. Might need a new owner of this.

@soates
Copy link
Owner

soates commented Nov 3, 2017

Will merge this in today.

@soates soates merged commit 461678b into soates:master Nov 3, 2017
@thorn0
Copy link

thorn0 commented Mar 8, 2018

Has it really been fixed? I still see the old behavior:
image

@Lindsor
Copy link

Lindsor commented Mar 8, 2018

Nope still seeing it as well

@rehmsen rehmsen mentioned this pull request Sep 6, 2018
Open
rehmsen added a commit to rehmsen/Auto-Import that referenced this pull request Sep 7, 2018
@rehmsen
Prevent import fixer from preprending ../ with ./
a395564 
That bug was fixed in the display of the fix, but because import fixing
was using a copy-and-pasted version of the path normalization code,
it never got the fix.

I tested this locally and now it actually works.

Fixes soates#37 (see PR soates#47 for the first attempt only fixing the display).
@rehmsen rehmsen mentioned this pull request Sep 7, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@robindijkhof @SamVerschueren @Lindsor @thomaswmanion @soates @thorn0