Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include vulnerabilities info along with remediation advice #194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmkanda
Copy link

@rmkanda rmkanda commented Dec 17, 2024

  • Tests written and linted ℹ︎
  • [] Commits are squashed and tidy and are suitable to become release notes

What this does

Explain why this PR exists

Notes for the reviewer

Instructions on how to run this locally, background context, what to review, questions…

More information

Screenshots

Visuals that may help the reviewer

@rmkanda rmkanda requested a review from a team as a code owner December 17, 2024 08:04
@thisislawatts
Copy link
Member

Thanks for proposing this change @rmkanda. Would you be able to add tests which validate the changes behave as expected when the data is present and well structured?

@rmkanda
Copy link
Author

rmkanda commented Jan 2, 2025

@thisislawatts I wont be able to verify it. I just don't want to update the excepted result with the new result blindly. Can we ask the code owner to check it?

I tested generating reports after the change. It looked good from user perspective.

@rmkanda
Copy link
Author

rmkanda commented Jan 2, 2025

In my opinion, we don't need to have "-a" option. We can include the remediation advice by default in the report. I will leave to Snyk team choice.

@thisislawatts
Copy link
Member

Thanks @rmkanda, we have this item on our backlog and will prioritise the work as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants