-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update travis tests to use stages + add support for java 8, 9, 10 & 11 #60
Comments
@lili2311, |
Please do :) |
Just let me know what sbt versions are supported so I can have a baseline to start with? |
Yep of course forgot to add this in: |
Following with a similar pattern as to the mvn-plugin, does this look okay? stage 1 (current sbt version - 1.2.8):node 6 => java 9 stage 2 (0.13 + 1.2.8)node 8 => java 8 (0.13) |
Not sure it is worth testing 0.13 + java 13 / java 12 maybe 1.2.8 instead? otherwise 👍 |
Yeah, makes sense :) I’ve updated the list |
Should I use sdkman for this?
Is that okay or look at https://github.com/paulp/sbt-extras ? I see that is being used in the current travis setup. |
So the test fixtures already pin the Should verified before, getting repos mixed up |
Update based on snyk/snyk-sbt-plugin#60
Update based on snyk/snyk-sbt-plugin#60
Expected behaviour
The code is tested on various java & sbt versions
Actual behaviour
Only default java version is tested with various sbt versions
Example
Here is an example travis config that would be ideal: https://github.com/snyk/snyk-gradle-plugin/pull/84/files
The text was updated successfully, but these errors were encountered: