Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helm add pod security context value #1524

Merged
merged 3 commits into from
Oct 1, 2024
Merged

feat: helm add pod security context value #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e51de40
feat: make pod securitycontext configurable in helm chart
Gianluca755 Aug 23, 2024
4dd18a1
fix: include fsgroup override for backwards compatibility
Gianluca755 Oct 1, 2024
8dd5d6f
fix: re-introduce missing default value
jonnyowenpowell Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions snyk-monitor/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,19 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
{{- with .Values.securityContext.fsGroup }}
securityContext:
fsGroup: {{ int . }}
{{- end }}
{{- with .Values.podSecurityContext }}
securityContext:
{{- $fsGroupOverride := dict }}
{{- if hasKey $.Values.securityContext "fsGroup" }}
{{- $fsGroupOverride = dict "fsGroup" (int $.Values.securityContext.fsGroup) }}
{{- end }}
{{- merge $fsGroupOverride . | toYaml | nindent 8 }}
{{- else }}
{{- if .Values.securityContext.fsGroup }}
securityContext:
fsGroup: {{ int .Values.securityContext.fsGroup }}
{{- end }}
{{- end }}
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
Expand Down Expand Up @@ -250,14 +259,10 @@ spec:
exec:
command:
- "true"
{{- with .Values.snykMonitorSecurityContext }}
securityContext:
privileged: false
runAsNonRoot: true
allowPrivilegeEscalation: false
readOnlyRootFilesystem: true
capabilities:
drop:
- ALL
{{- toYaml . | nindent 12 }}
{{- end }}
volumes:
- name: docker-config
secret:
Expand Down
21 changes: 19 additions & 2 deletions snyk-monitor/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,25 @@ excludedNamespaces:
# spec:
# securityContext:
# fsGroup: <-- here
securityContext:
fsGroup:
# ... <-- here
securityContext: {}

# Allow specifying the whole object in the PodSpec securityContext:
# spec:
# template:
# spec:
# securityContext:
# ... <-- here
podSecurityContext: {}

snykMonitorSecurityContext:
privileged: false
runAsNonRoot: true
allowPrivilegeEscalation: false
readOnlyRootFilesystem: true
capabilities:
drop:
- ALL

# Set node tolerations for snyk-monitor
tolerations: []
Expand Down