Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/convert to ts #835

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Chore/convert to ts #835

merged 2 commits into from
Oct 28, 2019

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Oct 28, 2019 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Update some tests to use ts & async / await

@lili2311 lili2311 requested a review from a team as a code owner October 28, 2019 09:13
@lili2311 lili2311 self-assigned this Oct 28, 2019
@ghost ghost requested review from lwywoo and orsagie October 28, 2019 09:13
@snyksec
Copy link

snyksec commented Oct 28, 2019 •
edited
Loading

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against e92aa4c

@lili2311 lili2311 force-pushed the chore/convert-to-ts branch from 79ca869 to 602f630 Compare October 28, 2019 09:22
@lili2311 lili2311 force-pushed the chore/convert-to-ts branch from 602f630 to e92aa4c Compare October 28, 2019 10:46
@lili2311 lili2311 merged commit 124984a into master Oct 28, 2019
@lili2311 lili2311 deleted the chore/convert-to-ts branch October 28, 2019 11:26
@snyksec
Copy link

snyksec commented Oct 28, 2019

🎉 This PR is included in version 1.239.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@joshje joshje mentioned this pull request May 13, 2022
Open
@aliscco aliscco mentioned this pull request May 13, 2022
Open
@cloudgeek7 cloudgeek7 mentioned this pull request May 14, 2022
Open
@joshje joshje mentioned this pull request Jun 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsagie orsagie orsagie approved these changes

@lwywoo lwywoo Awaiting requested review from lwywoo

Assignees

@lili2311 lili2311

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lili2311 @snyksec @orsagie