Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to open #746

Merged
merged 1 commit into from
Aug 25, 2019
Merged

feat: switch to open #746

merged 1 commit into from
Aug 25, 2019

Conversation

jamesgeorge007
Copy link

@jamesgeorge007 jamesgeorge007 commented Aug 23, 2019 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Dropped opn and made the necessary workarounds to use open instead.

opn was deprecated and renamed to open

related: #1679

@jamesgeorge007
feat: switch to open
d7279f6 
opn was deprecated and renamed to open
@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner August 23, 2019 06:30
@CLAassistant
Copy link

CLAassistant commented Aug 23, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ghost ghost requested review from lwywoo and miiila August 23, 2019 06:31
@jamesgeorge007 jamesgeorge007 mentioned this pull request Aug 23, 2019
Closed
@dkontorovskyy dkontorovskyy changed the base branch from master to feat/switch-to-open August 25, 2019 09:19
@dkontorovskyy dkontorovskyy merged this pull request into snyk:feat/switch-to-open Aug 25, 2019
@dkontorovskyy
Copy link
Contributor

Hello, @jamesgeorge007!
Thanks much for your contribution. In order your changes to be released, I need to pull them in side branch (so tests will pass on behalf of Snyk team) and release them to master. I will keep you posted.
And thanks for your contribution!

@dkontorovskyy dkontorovskyy mentioned this pull request Aug 25, 2019
Closed
3 tasks
@jamesgeorge007 jamesgeorge007 deleted the feat/switch-to-open branch August 25, 2019 10:17
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@robin-qualityengineer robin-qualityengineer mentioned this pull request May 23, 2022
Open
This was referenced May 23, 2022
Open
Open
@froscheimer froscheimer mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 24, 2022
Open
@EitanGayor EitanGayor mentioned this pull request Jun 30, 2022
Open
@aliscco aliscco mentioned this pull request Aug 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2022
Open
This was referenced Sep 25, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 1, 2022
Open
@aliscco aliscco mentioned this pull request Oct 2, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2022
Open
This was referenced Feb 19, 2023
Merged
Open
@cloudgeek7 cloudgeek7 mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwywoo lwywoo Awaiting requested review from lwywoo

@miiila miiila Awaiting requested review from miiila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgeorge007 @CLAassistant @dkontorovskyy