Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper error handling for snyk test command #738

Merged
merged 1 commit into from
Aug 20, 2019
Merged

fix: proper error handling for snyk test command #738

merged 1 commit into from
Aug 20, 2019

Conversation

kyegupov
Copy link
Contributor

@kyegupov kyegupov commented Aug 19, 2019 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fixes the error handling so that we don't get the mysterious "Failed to get vulns" message for incorrect auth.

Drive-by: typescriptify fake-server

@kyegupov kyegupov requested a review from a team as a code owner August 19, 2019 15:08
@kyegupov kyegupov self-assigned this Aug 19, 2019
@ghost ghost requested review from dkontorovskyy and lwywoo August 19, 2019 15:08
@lili2311
Copy link
Contributor

Please add tests for these errors? Do existing tests cover it already?

@kyegupov kyegupov force-pushed the fix/snyk-test-error-handling branch from 2cee291 to a42a67b Compare August 19, 2019 17:37
@kyegupov
Copy link
Contributor Author

@lili2311 nope, weren't covered. Added.

@kyegupov kyegupov force-pushed the fix/snyk-test-error-handling branch 2 times, most recently from db0313c to 19aed8b Compare August 19, 2019 18:19
@kyegupov kyegupov force-pushed the fix/snyk-test-error-handling branch from 19aed8b to 5602cdf Compare August 19, 2019 18:32
lwywoo
lwywoo approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@lwywoo lwywoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyegupov kyegupov merged commit d49847c into master Aug 20, 2019
@kyegupov kyegupov deleted the fix/snyk-test-error-handling branch August 20, 2019 09:10
@snyksec
Copy link

snyksec commented Aug 20, 2019

🎉 This PR is included in version 1.217.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@robin-qualityengineer robin-qualityengineer mentioned this pull request May 23, 2022
Open
This was referenced May 23, 2022
Open
Open
@froscheimer froscheimer mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 24, 2022
Open
@EitanGayor EitanGayor mentioned this pull request Jun 30, 2022
Open
@aliscco aliscco mentioned this pull request Aug 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2022
Open
This was referenced Sep 25, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 1, 2022
Open
@aliscco aliscco mentioned this pull request Oct 2, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2022
Open
This was referenced Feb 19, 2023
Merged
Open
@cloudgeek7 cloudgeek7 mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwywoo lwywoo lwywoo approved these changes

@dkontorovskyy dkontorovskyy Awaiting requested review from dkontorovskyy

Assignees

@kyegupov kyegupov

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyegupov @lili2311 @snyksec @lwywoo