Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Send ignorePolicyOption to the server #704

Merged
merged 2 commits into from
Aug 1, 2019
Merged

feat: Send ignorePolicyOption to the server #704

merged 2 commits into from
Aug 1, 2019

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jul 31, 2019 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • convert src/lib/snyk-test/common.js to src/lib/snyk-test/common.ts
  • send ignorePolicy as a query param to server so we can start acting on it in a future PR

@lili2311 lili2311 requested a review from a team July 31, 2019 14:28
@lili2311 lili2311 self-assigned this Jul 31, 2019
@ghost ghost requested review from dkontorovskyy and lwywoo July 31, 2019 14:28
@lili2311 lili2311 changed the title chore: convert to ts feat: Send ignorePolicyOption to the server Jul 31, 2019
@lili2311 lili2311 force-pushed the feat/send-ignore-policy-option-on-test branch from 371d5d8 to ad62f31 Compare July 31, 2019 14:41
@lili2311 lili2311 force-pushed the feat/send-ignore-policy-option-on-test branch from ad62f31 to 154a510 Compare July 31, 2019 14:46
dkontorovskyy
dkontorovskyy approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lili2311 lili2311 force-pushed the feat/send-ignore-policy-option-on-test branch from 154a510 to d184e4e Compare July 31, 2019 16:15
@lili2311 lili2311 merged commit 0007d0f into master Aug 1, 2019
@lili2311 lili2311 deleted the feat/send-ignore-policy-option-on-test branch August 1, 2019 09:21
@snyksec
Copy link

snyksec commented Aug 1, 2019

🎉 This PR is included in version 1.208.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Jan 1, 2020
Merged
This was referenced Jul 9, 2020
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 7, 2020
Open
This was referenced Aug 16, 2020
Open
Open
Open
Open
This was referenced Aug 27, 2020
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 28, 2020
Open
@EitanGayor EitanGayor mentioned this pull request Feb 22, 2021
Open
@romathur romathur mentioned this pull request Feb 22, 2021
Open
@EitanGayor EitanGayor mentioned this pull request Feb 23, 2021
Open
@joshje joshje mentioned this pull request Feb 23, 2021
Open
@RyanPHigh RyanPHigh mentioned this pull request Feb 23, 2021
Open
This was referenced Jul 27, 2022
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2022
Open
@shaniHerz shaniHerz mentioned this pull request Oct 3, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 19, 2023
Merged
@AliADDOU AliADDOU mentioned this pull request Apr 15, 2024
Open
@romathur romathur mentioned this pull request Apr 16, 2024
Open
@RyanPHigh RyanPHigh mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkontorovskyy dkontorovskyy dkontorovskyy approved these changes

@lwywoo lwywoo Awaiting requested review from lwywoo

Assignees

@lili2311 lili2311

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lili2311 @snyksec @dkontorovskyy