Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move message from stdout to stderr #4455

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: move message from stdout to stderr #4455

merged 1 commit into from
Mar 6, 2023

Conversation

PeterSchafer
Copy link
Collaborator

What does this PR do?

Move "Download" message to stderr to not interfer with other output

@PeterSchafer PeterSchafer requested review from a team as code owners March 6, 2023 12:44
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023 •
edited
Loading

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • ts-binary-wrapper/src/common.ts

Generated by 🚫 dangerJS against 2686818

@PeterSchafer PeterSchafer force-pushed the fix/move_download_message branch from d7f26eb to 2686818 Compare March 6, 2023 12:46
@PeterSchafer PeterSchafer merged commit 1e09ff7 into master Mar 6, 2023
@PeterSchafer PeterSchafer deleted the fix/move_download_message branch March 6, 2023 12:48
@MaxMood96 MaxMood96 mentioned this pull request May 13, 2024
Open
@claireksnyk claireksnyk mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelkaporin michelkaporin michelkaporin approved these changes

@ShiriV ShiriV Awaiting requested review from ShiriV ShiriV was automatically assigned from snyk/snyk-open-source

@snyk-tim snyk-tim Awaiting requested review from snyk-tim snyk-tim was automatically assigned from snyk/snyk-open-source

@robh-snyk robh-snyk Awaiting requested review from robh-snyk robh-snyk was automatically assigned from snyk/snyk-open-source

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterSchafer @michelkaporin