fix: none custom policies severity issues should be filtered out before sending them to registry

[wbeuil]

• Follows CONTRIBUTING rules

What does this PR do?

Related to this Tier 3 Zendesk ticket where if you tried to send to /iac-share-results endpoint issues with custom policies set to NONE in the Snyk UI, you were getting an error using the --report in the CLI. Whereas, without the --report flag, everything works fine.

Behind the user experience, the problem is that we got a weird bug where registry send back to the CLI a 400 introduced in this PR and we're now throwing an error back to the client due to a change of errors handling introduced here.

This PR is simply filtering NONE custom policies severity issues prior to sending them through the /iac-share-results endpoint.

How should this be manually tested?

Create a simple terraform file like this one:

resource "aws_s3_bucket" "this" {
  force_destroy = true
}

And then run this first command to check that it works fine without any custom policies:

$ snyk iac test <YOUR_TERRAFORM_FILE>

Go into Snyk UI and change one policies to NONE:

And rerun the above command, it should send only the other issues and not the one you changed in the UI.

What are the relevant tickets?

Zendesk ticket

[github-actions]

	Warnings
⚠️	"fix: none custom policies severity issues should be filtered out before sending them to registry" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 4acacd2

[ipapast]

looks good, thank you!