Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@snyk/fix: Extract requirements.txt version provenance (-r, -c directives) #1738

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Mar 17, 2021

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • introduce a function that can recursively detect -r and -c directive in req.txt Python pip manifests, fetch the referenced files & process them recursively so the provenance data can be used to apply fixes.

@lili2311 lili2311 self-assigned this Mar 17, 2021
@lili2311 lili2311 force-pushed the feat/extract-python-provenance branch 2 times, most recently from 3a04258 to 116b120 Compare March 17, 2021 17:46
@lili2311 lili2311 changed the title feat: detect & process required files @snyk/fix: Extract requirements.txt version provenance (-r, -c directives) Mar 17, 2021
@lili2311 lili2311 marked this pull request as ready for review March 17, 2021 18:14
@lili2311 lili2311 requested a review from a team March 17, 2021 18:14
@lili2311 lili2311 force-pushed the feat/extract-python-provenance branch from 116b120 to f901041 Compare March 18, 2021 12:34
Function to extract Python provenance data & tests to:
- detect -r and -c directive
- read the file & extract dependencies
- check for -r and -c directive (recursively)
- return provenance which is all deps per detected manifest
as part of this chain.
@lili2311 lili2311 force-pushed the feat/extract-python-provenance branch from f901041 to f4563ec Compare March 18, 2021 14:26
@lili2311 lili2311 merged commit e92f816 into master Mar 18, 2021
@lili2311 lili2311 deleted the feat/extract-python-provenance branch March 18, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants