Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Cloud Config support #1140

Merged
merged 8 commits into from
Jun 29, 2020
Merged

feat: add Cloud Config support #1140

merged 8 commits into from
Jun 29, 2020

Conversation

orkamara
Copy link
Contributor

@orkamara orkamara commented May 24, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Support Cloud Config (AKA IaC) as part of the CLI.
Right now we scan only Kubernetes files (using the --file flag).

Notes for the reviewer

@orkamara orkamara requested a review from orsagie May 24, 2020 15:36
@orkamara orkamara force-pushed the feat/support-cloud-config branch from 7c1f4ff to f799487 Compare May 24, 2020 15:39
@Shesekino
Copy link
Contributor

could you split this to several smaller commits with more precise changes please? it would be much easier to review in my opinion

@orkamara orkamara force-pushed the feat/support-cloud-config branch 2 times, most recently from a1578ad to 6aa4d39 Compare May 25, 2020 06:33
@orkamara
Copy link
Contributor Author

could you split this to several smaller commits with more precise changes please? it would be much easier to review in my opinion

That's what I'm doing right now :)

@orkamara orkamara force-pushed the feat/support-cloud-config branch from 6aa4d39 to 1128865 Compare May 31, 2020 14:21
@orkamara orkamara force-pushed the feat/support-cloud-config branch from 1128865 to 89a0e31 Compare June 10, 2020 10:07
@orkamara orkamara force-pushed the feat/support-cloud-config branch 10 times, most recently from 6924c5a to d6a7130 Compare June 24, 2020 06:29
@orkamara orkamara self-assigned this Jun 24, 2020
@orkamara orkamara force-pushed the feat/support-cloud-config branch from d6a7130 to 9c2c647 Compare June 24, 2020 06:32
@orkamara orkamara added the 🚧 WIP Work In Progress label Jun 24, 2020
@orkamara orkamara marked this pull request as ready for review June 24, 2020 06:37
@orkamara orkamara requested review from a team as code owners June 24, 2020 06:37
@ghost ghost requested review from anthogez and MegaBean June 24, 2020 06:37
@Shesekino Shesekino merged commit 5a22e6a into master Jun 29, 2020
@Shesekino Shesekino deleted the feat/support-cloud-config branch June 29, 2020 10:13
@snyksec
Copy link

snyksec commented Jun 29, 2020

🎉 This PR is included in version 1.350.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants