Use correct Y axis direction #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WGPU 0.4 has Y axis pointing Down nuklear-backend-wgpurs assumes (in projection matrix) it points up, but also knows it must point down and performs costly y coordinate fix by iterating all vertices. This change removes the costly iteration, and changes the projection matrix to use WGPU 0.4's natural Y axis direction
2asoft
force-pushed
the
performance_fix
branch
from
f73d9e4 to
d68ed22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WGPU 0.4 has Y axis pointing Down
nuklear-backend-wgpurs assumes (in projection matrix) it points up, but also knows it must point down and performs costly y coordinate fix by iterating all vertices.
This change removes the costly iteration, and changes the projection matrix to use WGPU 0.4's natural Y axis direction.
The effect is rather dramatic (on my machine, so YMMV).
The iteration (with
const MAX_VERTEX_MEMORY: usize = 512 * 1024;) used to take 26-50ms, which increased frame render time.With this gone, overhead of this backend is negligible.