Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filterWithKey and bump classyprelude cabal version #232

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

L0neGamer
Copy link
Contributor

@L0neGamer L0neGamer commented Jul 12, 2024

closes #218

also adding dist-newstyle to the gitignore list

@BebeSparkelSparkel

@BebeSparkelSparkel
Copy link
Collaborator

@L0neGamer Please add to mono-traversable/ChangeLog.md

@BebeSparkelSparkel
Copy link
Collaborator

@gregwebs When working with snoyberg on PRs he did not have me up the prelude versions when functionality was added to mono-traversable. What is your opinion on this?

Considering that ClassyPrelude.hs imports with hiding it does not make sense to me to up the version if the dependencies export more.

@gregwebs
Copy link
Collaborator

yeah classy prelude only needs to be bumped if it is exporting new things.

@BebeSparkelSparkel
Copy link
Collaborator

The version of classy-prelude should remain unchanged.

@L0neGamer
Copy link
Contributor Author

the version is unchanged, I used the wrong language; the cabal file was updated because stack was run at some point.

@BebeSparkelSparkel
Copy link
Collaborator

@L0neGamer #234 fixed the classy-prelude cabal version. Try rebasing on master and ensure that classy-prelude/classy-prelude.cabal is unchanged and this should be ready to pull.

@BebeSparkelSparkel BebeSparkelSparkel merged commit 8e99fdf into snoyberg:master Jul 13, 2024
19 checks passed
@BebeSparkelSparkel
Copy link
Collaborator

@L0neGamer Thanks for the help!
@gregwebs Appreciate the input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering with key
3 participants