Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add org.w3/PerformanceNavigationTiming/jsonschema/1-0-0 close (#1294) #1295

Closed
wants to merge 1 commit into from
Closed

Add org.w3/PerformanceNavigationTiming/jsonschema/1-0-0 close (#1294) #1295

wants to merge 1 commit into from

Conversation

igneel64
Copy link
Contributor

Add PerformanceNavigationTiming schema which aims to model values from the Navigation timing specification.

close (#1294)

matus-tomlein
matus-tomlein approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

schemas/org.w3/PerformanceNavigationTiming/jsonschema/1-0-0 Show resolved Hide resolved
schemas/org.w3/PerformanceNavigationTiming/jsonschema/1-0-0 Outdated Show resolved Hide resolved
@igneel64 igneel64 force-pushed the issue/1294-w3_performance_navigation_timing branch 2 times, most recently from 56a12a5 to 72ebdf1 Compare April 25, 2023 09:33
jethron
jethron approved these changes Apr 26, 2023
View reviewed changes
Copy link

@jethron jethron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the serverTiming part.

schemas/org.w3/PerformanceNavigationTiming/jsonschema/1-0-0 Outdated Show resolved Hide resolved
schemas/org.w3/PerformanceNavigationTiming/jsonschema/1-0-0 Outdated Show resolved Hide resolved
schemas/org.w3/PerformanceNavigationTiming/jsonschema/1-0-0 Outdated Show resolved Hide resolved
schemas/org.w3/PerformanceNavigationTiming/jsonschema/1-0-0 Outdated Show resolved Hide resolved
schemas/org.w3/PerformanceNavigationTiming/jsonschema/1-0-0 Show resolved Hide resolved
@igneel64 igneel64 force-pushed the issue/1294-w3_performance_navigation_timing branch from 72ebdf1 to ba9919a Compare April 26, 2023 11:42
@igneel64 igneel64 force-pushed the issue/1294-w3_performance_navigation_timing branch from ba9919a to 965ec0c Compare April 28, 2023 05:47
@igneel64
Copy link
Contributor Author

@jethron The fixes for server timing are up and we have added a mitigation for the negative values bugs (minimum values). If you think it is fine, I will be adding this on #1258

@igneel64 igneel64 requested a review from jethron April 28, 2023 05:48
jethron
jethron approved these changes May 2, 2023
View reviewed changes
Copy link

@jethron jethron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igneel64
Copy link
Contributor Author

igneel64 commented May 2, 2023

Added on #1258

@igneel64 igneel64 closed this May 2, 2023
@igneel64 igneel64 deleted the issue/1294-w3_performance_navigation_timing branch May 2, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matus-tomlein matus-tomlein matus-tomlein approved these changes

@jethron jethron jethron approved these changes

@istreeter istreeter Awaiting requested review from istreeter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igneel64 @matus-tomlein @jethron @istreeter