Kinesis source must report its latency when KCL is not healthy #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
force-pushed
the
crash-on-unhealthy-kcl
branch
from
2220fd8 to
dd179d6
Compare
istreeter
changed the title
istreeter
force-pushed
the
crash-on-unhealthy-kcl
branch
2 times, most recently
from
d5fdd15 to
e4b0198
Compare
pondzix
reviewed
May 17, 2024
...ams-core/src/main/scala/com.snowplowanalytics.snowplow/sources/internal/LowLevelSource.scala
Outdated
Show resolved
Hide resolved
spenes
force-pushed
the
crash-on-unhealthy-kcl
branch
from
e4b0198 to
53eb2b5
Compare
pondzix
approved these changes
May 28, 2024
spenes
force-pushed
the
crash-on-unhealthy-kcl
branch
from
470c1cd to
cd34931
Compare
The KCL is sadly not very good at crashing and exiting. If the underlying Kinesis client has errors (e.g. permissions errors) then KCL tends to stay alive and not propagate the exceptions to our application code. We want the app to crash under these circumstances because that triggers an alert. common-streams already has a health check feature, in which a health probe becomes unhealthy if a single event gets stuck without making progress. This PR leans on the existing health check feature, so it also becomes unhealthy if the Kinesis client is not regularly receiving healthy responses. I configured KCL to invoke our record processor every time it polls for records, even if the batch is empty. This means the health check still works even if there are no events in the stream.
spenes
force-pushed
the
crash-on-unhealthy-kcl
branch
from
cd34931 to
be1fdb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of PDP-1196
The KCL is sadly not very good at crashing and exiting. If the underlying Kinesis client has errors (e.g. permissions errors) then KCL tends to stay alive and not propagate the exceptions to our application code. We want the app to crash under these circumstances because that triggers an alert.
common-streams already has a health check feature, in which a health probe becomes unhealthy if a single event gets stuck without making progress.
This PR leans on the existing health check feature, so it also becomes unhealthy if the Kinesis client is not regularly receiving healthy responses.
I configured KCL to invoke our record processor every time it polls for records, even if the batch is empty. This means the health check still works even if there are no events in the stream.