Support GET queries by list and ID #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @digitalpoetry sorry for the delay in responding to you here - would you mind rebasing on master and ill take a look and get your changes merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added methods for getting Redash queries as a list and getting a Redash query by ID.
I'm hoping to contribute to https://github.com/snowplow-devops/terraform-provider-redash by adding support for managing queries and dashboards. This starts with adding functionality for CRUD operations on these resources from the Redash client.
In the interest of keeping PRs small, here's the first. I'll add create, update, delete operations in another PR.
Do let me know if you have any feedback. Thanks!