Retry infinitely on expired shard iterator error

snowplow-devops · Nov 13, 2024 · 8cc8e5a · 8cc8e5a
1 parent 9b8b911
commit 8cc8e5a
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/shard_consumer.go b/shard_consumer.go
@@ -202,22 +202,25 @@ mainloop:
 				if awsErr.OrigErr() != nil {
 					origErrStr = fmt.Sprintf("(%s) ", awsErr.OrigErr())
 				}
-				k.config.logger.Log("Got error: %s %s %sretry count is %d / %d", awsErr.Code(), awsErr.Message(), origErrStr, retryCount, maxErrorRetries)
-				// Only retry for errors that should be retried; notably, don't retry serialization errors because something bad is happening
-				shouldRetry := request.IsErrorRetryable(err) || request.IsErrorThrottle(err)
 
 				switch awsErr.Code() {
 				case kinesis.ErrCodeExpiredIteratorException:
+					k.config.logger.Log("Got error: %s %s %s", awsErr.Code(), awsErr.Message(), origErrStr)
 					newIterator, ierr := getShardIterator(k.kinesis, k.streamName, shardID, lastSeqToCheckp, nil)
 					if ierr != nil {
 						k.shardErrors <- shardConsumerError{shardID: shardID, action: "getShardIterator", err: err}
 						return
 					}
 					iterator = newIterator
-					// should retry after expired iterator is renewed successfully
-					shouldRetry = true
+
+					// retry infinitely after expired iterator is renewed successfully
+					continue mainloop
 				}
 
+				// Only retry for errors that should be retried; notably, don't retry serialization errors because something bad is happening
+				shouldRetry := request.IsErrorRetryable(err) || request.IsErrorThrottle(err)
+				k.config.logger.Log("Got error: %s %s %sretry count is %d / %d", awsErr.Code(), awsErr.Message(), origErrStr, retryCount, maxErrorRetries)
+
 				if shouldRetry && retryCount < maxErrorRetries {
 					retryCount++