Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-SNOW speed up Iceberg schema evolution test #1028

Merged
merged 2 commits into from
Dec 13, 2024
Merged

NO-SNOW speed up Iceberg schema evolution test #1028

merged 2 commits into from
Dec 13, 2024
+4 −11

Conversation

sfc-gh-bzabek
Copy link
Contributor

@sfc-gh-bzabek sfc-gh-bzabek commented Dec 13, 2024 •
edited
Loading

Overview

NO-SNOW

Low hanging fruit.
waitForOffset(i) takes a lot of time. It's not necessary to wait every time record is inserted. This simple change reduced test time from ~13:30 to 8:12 minutes.

I executed tests a couple of times to make sure they are no flaky.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-bzabek sfc-gh-bzabek marked this pull request as ready for review December 13, 2024 10:16
@sfc-gh-bzabek sfc-gh-bzabek requested a review from a team as a code owner December 13, 2024 10:16
@sfc-gh-bzabek sfc-gh-bzabek marked this pull request as draft December 13, 2024 10:17
@sfc-gh-bzabek sfc-gh-bzabek marked this pull request as ready for review December 13, 2024 10:19
@sfc-gh-bzabek sfc-gh-bzabek enabled auto-merge (squash) December 13, 2024 10:26
@sfc-gh-bzabek sfc-gh-bzabek merged commit e21bdf8 into master Dec 13, 2024
49 of 54 checks passed
@sfc-gh-bzabek sfc-gh-bzabek deleted the bzabek-NO-SNOW-speed-up-tests branch December 13, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-wtrefon sfc-gh-wtrefon sfc-gh-wtrefon approved these changes

@sfc-gh-mbobowski sfc-gh-mbobowski sfc-gh-mbobowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-bzabek @sfc-gh-mbobowski @sfc-gh-wtrefon