SNOW-1820302 Integrate with ingest sdk 3.0.1 #1016
Merged
+10
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mbobowski
force-pushed
the
mbobowski-SNOW-1820302-sdk-3.0.1
branch
from
f0cf9f5 to
9fa62c8
Compare
sfc-gh-rsawicki
approved these changes
Dec 5, 2024
| @@ -61,26 +61,13 @@ private IcebergColumnSchema mapIcebergSchemaFromChannel( | |||
| Map.Entry<String, ColumnProperties> schemaFromChannelEntry) { | |||
|
|
|||
| ColumnProperties columnProperty = schemaFromChannelEntry.getValue(); | |||
| String plainIcebergSchema = getIcebergSchema(columnProperty); | |||
| String plainIcebergSchema = columnProperty.getIcebergSchema(); | |||
sfc-gh-wtrefon
approved these changes
Dec 5, 2024
sfc-gh-dseweryn
approved these changes
Dec 5, 2024
| @@ -261,7 +256,7 @@ public void testComplexRecordEvolution() throws Exception { | |||
| new DescribeTableRow("APPROVAL", "BOOLEAN"), | |||
| new DescribeTableRow("ARRAY1", "ARRAY(NUMBER(19,0))"), | |||
| new DescribeTableRow("ARRAY2", "ARRAY(VARCHAR(16777216))"), | |||
| new DescribeTableRow("ARRAY3", "ARRAY(BOOLEAN)"), | |||
| new DescribeTableRow("ARRAY3", "ARRAY(VARCHAR(16777216))"), | |||
There was a problem hiding this comment.
Sry I missed that somehow.
There was a problem hiding this comment.
No problem, it happens without the CI.
There was a problem hiding this comment.
funny thing, I didn't notice it in my PR as this is the expected result. Now this breaks my PR, have to rollback this line :D
There was a problem hiding this comment.
now i feel sad that i find such things "funny"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1820302
Pre-review checklist
snowflake.ingestion.method.Yes- Added end to end and Unit Tests.No- Suggest why it is not param protected