Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Snow 1651983 upgrade azure storage sdk v8 to v12, fix authenticated proxy issue #1895

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[DRAFT] Snow 1651983 upgrade azure storage sdk v8 to v12, fix authenticated proxy issue #1895

wants to merge 3 commits into from
+398 −290

Conversation

sfc-gh-mkubik
Copy link
Contributor

@sfc-gh-mkubik sfc-gh-mkubik commented Sep 16, 2024 •
edited by jira bot
Loading

Overview

The azure-storage sdk aka v8 is on the retirement path (retirement notice). At the same time it seems that it's causing problems with accessing stages via authenticated proxy.

This PR addresses both issues by migrating the azure-storage sdk (v8) to azure-storage-blob sdk (v12)

SNOW-1651983

TODO

  • Introduce new unit/integ tests as not all of the introduced changes are covered by existing tests.
  • Test in different enviroments (currently only local dev-tests were preformed)

Testing

  • Repo's unit, integ tests
  • Manual PUT/GET test using locally set up authenticated proxy

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

sfc-gh-mhofman and others added 3 commits September 5, 2024 21:00
@sfc-gh-mhofman
SNOW-1651983 authenticated proxy on azure
20242c6
@sfc-gh-astachowski
Formatting
0e8de1a
@sfc-gh-mkubik
Initial azure-storage-blob sdk bump
8656d34 
Migrates the azure storage interactions to the V12 api. Still WIP, requires additional error handling, a bit of refactoring and new unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-mkubik @sfc-gh-mhofman @sfc-gh-astachowski