Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-732360: Allow connection caching to be disabled by user #1845

Merged

Conversation

sfc-gh-ext-simba-jf
Copy link
Collaborator

Overview

SNOW-732360

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

Added new connection parameters:
clientStoreTemporaryCredential -> default true
clientRequestMfaToken -> default true
To allow user to disable connection caching on windows and mac osx

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf requested a review from a team as a code owner July 25, 2024 10:03
@sfc-gh-pbulawa sfc-gh-pbulawa changed the title Allow connection caching to be disabled by user SNOW-732360: Allow connection caching to be disabled by user Aug 29, 2024
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 3ede535 into master Aug 29, 2024
140 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the Snow-732360-Allow-Connection-Caching-to-be-Disabled branch August 29, 2024 10:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants