Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1446336: Use S3 regional url domain base on region name #1768

Merged
merged 1 commit into from
May 27, 2024
Merged

SNOW-1446336: Use S3 regional url domain base on region name #1768

merged 1 commit into from
May 27, 2024

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Overview

SNOW-1446336

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner May 24, 2024 11:23
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 3c4b521 into master May 27, 2024
34 of 37 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1446336-use-s3-regional-url-domain-base-on-region-name branch May 27, 2024 05:37
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-dprzybysz @sfc-gh-pfus