Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-829489: Fix CLA Bot #511

Merged
merged 1 commit into from
Jun 2, 2023
Merged

SNOW-829489: Fix CLA Bot #511

merged 1 commit into from
Jun 2, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Fix CLA Bot.

Checklist

  • Format code according to the existing code style (there is no automatic linter yet)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner June 1, 2023 07:19
sfc-gh-dprzybysz
sfc-gh-dprzybysz approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-igarish
sfc-gh-igarish approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz
Copy link
Collaborator

recheck

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit f47a425 into master Jun 2, 2023
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-829489-fix-cla branch June 2, 2023 09:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki Awaiting requested review from sfc-gh-pmotacki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pbulawa @sfc-gh-dprzybysz @sfc-gh-igarish