Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Streamlit in docs #881

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix Streamlit in docs #881

merged 1 commit into from
Mar 12, 2024

Conversation

sfc-gh-astus
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Changed Streamlit to Streamlit app

@sfc-gh-astus sfc-gh-astus force-pushed the fix-streamlit-app-name branch 2 times, most recently from cc0d2fe to 3b96cd7 Compare March 8, 2024 09:42
sfc-gh-mheavin
sfc-gh-mheavin reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-mheavin sfc-gh-mheavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

I did not continue with the "test" files, as they don't seem to be user-visible.

In general, please make sure you use "the" or "a" before "Streamlit app"

src/snowflake/cli/plugins/streamlit/commands.py Outdated Show resolved Hide resolved
src/snowflake/cli/plugins/streamlit/commands.py Outdated Show resolved Hide resolved
src/snowflake/cli/plugins/streamlit/commands.py Outdated Show resolved Hide resolved
src/snowflake/cli/plugins/streamlit/commands.py Outdated Show resolved Hide resolved
src/snowflake/cli/plugins/streamlit/commands.py Outdated Show resolved Hide resolved
tests/__snapshots__/test_help_messages.ambr Outdated Show resolved Hide resolved
tests/__snapshots__/test_help_messages.ambr Outdated Show resolved Hide resolved
tests/__snapshots__/test_help_messages.ambr Outdated Show resolved Hide resolved
tests/__snapshots__/test_help_messages.ambr Outdated Show resolved Hide resolved
tests/__snapshots__/test_help_messages.ambr Outdated Show resolved Hide resolved
@sfc-gh-astus sfc-gh-astus force-pushed the fix-streamlit-app-name branch from 3b96cd7 to 3166678 Compare March 11, 2024 09:44
@sfc-gh-astus sfc-gh-astus requested a review from a team as a code owner March 11, 2024 09:44
@sfc-gh-astus sfc-gh-astus force-pushed the fix-streamlit-app-name branch from 3166678 to 78fa0cb Compare March 11, 2024 09:53
sfc-gh-mheavin
sfc-gh-mheavin approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-mheavin sfc-gh-mheavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@sfc-gh-astus sfc-gh-astus force-pushed the fix-streamlit-app-name branch from 78fa0cb to 9a34512 Compare March 12, 2024 11:32
@sfc-gh-astus sfc-gh-astus force-pushed the fix-streamlit-app-name branch from 9a34512 to f9d9478 Compare March 12, 2024 14:49
@sfc-gh-astus sfc-gh-astus merged commit 03603f2 into main Mar 12, 2024
10 checks passed
@sfc-gh-astus sfc-gh-astus deleted the fix-streamlit-app-name branch March 12, 2024 15:26
@sfc-gh-pjob sfc-gh-pjob removed the 2.1.1 label Mar 19, 2024
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-astus
Fix Streamlit in docs (#881)
cf4ae4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mheavin sfc-gh-mheavin sfc-gh-mheavin approved these changes

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

@sfc-gh-pjob sfc-gh-pjob Awaiting requested review from sfc-gh-pjob

@sfc-gh-jsikorski sfc-gh-jsikorski Awaiting requested review from sfc-gh-jsikorski

@sfc-gh-mraba sfc-gh-mraba Awaiting requested review from sfc-gh-mraba

@sfc-gh-pczajka sfc-gh-pczajka Awaiting requested review from sfc-gh-pczajka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-astus @sfc-gh-turbaszek @sfc-gh-mheavin @sfc-gh-pjob