Refactor unreleased commands and hide released spcs flags instead of blocking #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "enable_spcs_service_events = true\n" | ||
| "enable_spcs_service_metrics = true\n" | ||
| ) | ||
| yield config_toml |
There was a problem hiding this comment.
Do we need to do this on config file? Mock is_enabled/is_disabled is more obvious and faster. WDYT?
There was a problem hiding this comment.
Unfortunately - mocking happens after the commands.py file is imported. During import is_enabled function is saved in app factory, which means it is not mocked :/
sfc-gh-pczajka
changed the title
sfc-gh-astus
approved these changes
Jan 14, 2025
sfc-gh-pczajka
deleted the
pczajka-hide-spcs-commands-instead-of-blocking
branch
sfc-gh-pczajka
added a commit
that referenced
this pull request
Jan 14, 2025
…blocking (#1989) * disable spcs commands if feature flag is disabled; hide logs instead of rising an error * Hide flag instead of command, fix tests * update snapshots * remove streaming flag
This was referenced Jan 14, 2025
Closed
Merged
sfc-gh-pczajka
added a commit
that referenced
this pull request
Jan 14, 2025
* SNOW-1843926: SPCS service events & metrics (#1954) * spcs service events&metrics * snapshot and feature flag * add new test * fix test * new table format and new test and new snapshot * fix comment * release notes * fix comments * snapshot update * update snapshots --------- Co-authored-by: Teja Kommineni <teja.kommineni@snowflake.com> Co-authored-by: Patryk Czajka <patryk.czajka@snowflake.com> * Refactor unreleased commands and hide released spcs flags instead of blocking (#1989) * disable spcs commands if feature flag is disabled; hide logs instead of rising an error * Hide flag instead of command, fix tests * update snapshots * remove streaming flag --------- Co-authored-by: Abby Shen <abby.shen@snowflake.com> Co-authored-by: Teja Kommineni <teja.kommineni@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
--followand--follow-intervalflags ifENABLE_SPCS_LOG_STREAMINGflag is disabledsnow spcs service metrics/eventscommands if their feature flags are not set