Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1706990 Remove NativeAppVersionCreateProcessor #1731

Merged
merged 1 commit into from
Oct 17, 2024
Merged

SNOW-1706990 Remove NativeAppVersionCreateProcessor #1731

merged 1 commit into from
Oct 17, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Updates version create tests to use ApplicationPackageEntity and removes NativeAppVersionCreateProcessor

@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review October 16, 2024 20:41
@sfc-gh-fcampbell sfc-gh-fcampbell requested a review from a team as a code owner October 16, 2024 20:41
sfc-gh-bdufour
sfc-gh-bdufour reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-bdufour sfc-gh-bdufour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to figure out from the diff, but are we still covering the legacy V1/V1.1 logic too? I couldn't find the answer.

@sfc-gh-fcampbell
Copy link
Contributor Author

This PR doesn't change what the tests test. Version create with v1 is tested here:

snowflake-cli/tests_integration/nativeapp/test_version.py

Line 66 in c69f78a

def test_nativeapp_version_create_and_drop(

@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 2a494c3 into main Oct 17, 2024
19 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-no-version-create-processor branch October 17, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-bdufour