Build and sign Windows installer #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pjob
commented
Oct 10, 2024
| @@ -17,7 +17,7 @@ def parse_version_for_windows_build() -> list[str]: | |||
| case last if "dev" in last: | |||
| version = msv + last.split("dev") | |||
|
|
|||
| return version | |||
| return [segment for segment in version if segment] | |||
There was a problem hiding this comment.
This fixes double dot error in version (3.1.0..0 -> 3.1.0.0).
| @@ -0,0 +1,2 @@ | |||
| REM DELETE THIS FILE | |||
There was a problem hiding this comment.
It can be deleted for target jobs configuration. Signature verification is now in build_installer.bat.
| REM snowflake_cli.wixobj ^ | ||
| REM snowflake_cli_exitdlg.wixobj ^ | ||
| REM _internal.wixobj | ||
| set PATH=C:\Program Files\7-Zip;C:\Users\jenkins\AppData\Local\Programs\Python\Python38;C:\Users\jenkins\AppData\Local\Programs\Python\Python38\Scripts;C:\Program Files (x86)\WiX Toolset v3.11\bin;%PATH% |
There was a problem hiding this comment.
Almost all the code is from @sfc-gh-pczajka branch: https://github.com/snowflakedb/snowflake-cli/tree/SNOW-1661610-sign-Windows-intaller
I changed the following:
- Added
|| goto :errorto crucial commands and addederrorlabel section at the end of the file. - Added
/d "Snowflake CLI"option tosigntool signto present a proper tool name in UAC dialog. - Added two invocations of
signtool verify- for snow.exe and for installer. - Removed hardcoded values for
REVISIONandRELEASE_TYPEvariables.
There was a problem hiding this comment.
TODO:
- review
- cleanup debugs and "echo on"
- upload MSI to a proper path at a stage (without staging part???)
- anything else I don't know about
sfc-gh-mraba
force-pushed
the
pjob/SNOW-1661610-sign-windows
branch
from
139bdb7 to
537109c
Compare
sfc-gh-mraba
approved these changes
Oct 11, 2024
sfc-gh-astus
approved these changes
Oct 11, 2024
sfc-gh-mraba
pushed a commit
that referenced
this pull request
Oct 11, 2024
sfc-gh-mraba
pushed a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Based on @sfc-gh-pczajka branch: https://github.com/snowflakedb/snowflake-cli/tree/SNOW-1661610-sign-Windows-intaller
devandrcversions (3.1.0..0->3.1.0.0)