Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1706990 Convert snow app run to v2-native #1684

Merged
merged 1 commit into from
Oct 9, 2024
Merged

SNOW-1706990 Convert snow app run to v2-native #1684

merged 1 commit into from
Oct 9, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Converts snow app run to operate natively on v2 entities, like snow ws deploy on an app entity.

@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-snow-app-deploy-v2-native branch from 1e66595 to f792e74 Compare October 8, 2024 14:25
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-snow-app-deploy-v2-native branch 3 times, most recently from 1c80bbf to 9246fa5 Compare October 9, 2024 14:49
Base automatically changed from frank-snow-app-deploy-v2-native to main October 9, 2024 15:45
@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review October 9, 2024 15:45
@sfc-gh-fcampbell sfc-gh-fcampbell requested a review from a team as a code owner October 9, 2024 15:45
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 9, 2024 15:47
sfc-gh-fcampbell
sfc-gh-fcampbell commented Oct 9, 2024
View reviewed changes
src/snowflake/cli/_plugins/nativeapp/entities/application.py
@@ -182,6 +184,54 @@ def deploy_package():
force=force,
)

def drop_application_before_upgrade(cascade: bool = False):
Copy link
Contributor Author

@sfc-gh-fcampbell sfc-gh-fcampbell Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to copy this code from NativeAppManager, it'll be refactored into action_drop later

@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 4af706c into main Oct 9, 2024
18 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-snow-app-run-v2 branch October 9, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mchok sfc-gh-mchok sfc-gh-mchok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-mchok