Introduce StagePath for working with files on stages #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-turbaszek
commented
Oct 7, 2024
| ["@repo/branches/main/s1.sql", "@repo/branches/main/a/S3.sql"], | ||
| ), | ||
| ( | ||
| "@repo/branches/main/a", | ||
| "@repo/branches/main/", | ||
| "@repo/branches/main", |
There was a problem hiding this comment.
To align the behavior. The StagePath accepts both inputs (with or without trailing /) but the representation is always without / suffix
sfc-gh-turbaszek
force-pushed
the
introduce-stage-path
branch
from
61383b6 to
177efb4
Compare
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| log = logging.getLogger(__name__) | |||
|
|
|||
| StagePath = PurePosixPath # alias PurePosixPath as StagePath for clarity | |||
| StagePathType = PurePosixPath # alias PurePosixPath as StagePath for clarity | |||
There was a problem hiding this comment.
This change is done to avoid ambiguity
sfc-gh-astus
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
StagePathtoStagePathTypeto avoid ambiguityStagePathclass representing a file on stage. This class offersPathlike operations includingjoinpathorparentoperations.The next step of refactor will be removing of
StagePathPartsconcepts and then moving query generation toStagePath.