Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1706990 Convert snow app deploy to v2-native #1672

Merged
merged 1 commit into from
Oct 9, 2024
Merged

SNOW-1706990 Convert snow app deploy to v2-native #1672

merged 1 commit into from
Oct 9, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

@sfc-gh-fcampbell sfc-gh-fcampbell commented Oct 4, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Makes snow app deploy operate natively on v2 entities, like snow ws deploy. Updates @single_app_and_package to keep the correct ctx.env.

@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-snow-app-deploy-v2-native branch 2 times, most recently from a2cc8bc to 3ca9861 Compare October 7, 2024 18:21
@sfc-gh-fcampbell sfc-gh-fcampbell changed the base branch from main to frank-bundle-map-relative-path October 7, 2024 18:22
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-snow-app-deploy-v2-native branch from 3ca9861 to 90caf42 Compare October 7, 2024 18:24
Base automatically changed from frank-bundle-map-relative-path to main October 8, 2024 08:10
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-snow-app-deploy-v2-native branch 2 times, most recently from f2f9788 to 7008f42 Compare October 8, 2024 15:37
@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review October 8, 2024 17:55
@sfc-gh-fcampbell sfc-gh-fcampbell requested review from a team as code owners October 8, 2024 17:55
sfc-gh-bdufour
sfc-gh-bdufour reviewed Oct 8, 2024
View reviewed changes
src/snowflake/cli/_plugins/nativeapp/entities/application_package.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests_common/deflake.py Outdated Show resolved Hide resolved
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-snow-app-deploy-v2-native branch from 8d62ae9 to f792e74 Compare October 8, 2024 19:02
@sfc-gh-fcampbell
Copy link
Contributor Author

oops, everything was from debugging these integ test failures, i removed it all, some of it did end up as separate PRs (#1693, #1692)

@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-snow-app-deploy-v2-native branch from f792e74 to 1c80bbf Compare October 9, 2024 14:04
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 9, 2024 14:05
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-snow-app-deploy-v2-native branch from 1c80bbf to 9246fa5 Compare October 9, 2024 14:49
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 186bbff into main Oct 9, 2024
21 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-snow-app-deploy-v2-native branch October 9, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-bdufour