Find deeply-nested manifest.yml when converting v1 to v2 #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-220
to
-222
| bundle_map = build_bundle( | ||
| project_root, Path(native_app.deploy_root), native_app.artifacts | ||
| ) |
There was a problem hiding this comment.
switched from build_bundle to just BundleMap since we don't actually need to copy the artifacts to find the manifest, we just need to resolve the mapping between source and destination
sfc-gh-fcampbell
force-pushed
the
frank-find-nested-manifest
branch
from
85f976d to
4054e22
Compare
sfc-gh-turbaszek
approved these changes
Sep 30, 2024
sfc-gh-jsikorski
pushed a commit
that referenced
this pull request
Sep 30, 2024
Fixes the manifest not being found if it isn't explicitly mentioned as an artifact or as part of a glob when running `snow helpers v1-to-v2`.
Merged
8 tasks
sfc-gh-jsikorski
pushed a commit
that referenced
this pull request
Sep 30, 2024
Fixes the manifest not being found if it isn't explicitly mentioned as an artifact or as part of a glob when running `snow helpers v1-to-v2`.
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
Fixes the manifest not being found if it isn't explicitly mentioned as an artifact or as part of a glob when running `snow helpers v1-to-v2`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Fixes the manifest not being found if it isn't explicitly mentioned as an artifact or as part of a glob when running
snow helpers v1-to-v2.