Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-859548 Replace test table in each test #858

Merged
merged 1 commit into from
Jul 21, 2023
Merged

SNOW-859548 Replace test table in each test #858

merged 1 commit into from
Jul 21, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Jul 20, 2023 •
edited
Loading

Description

Each test did a round trip or even two to drop tables, which were not created in most tests. Additionally, all test tables are dropped on the end of the suite, when the whole schema is dropped.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review July 20, 2023 09:55
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner July 20, 2023 09:55
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-859548-replace-table-test branch from 7a7ccfb to aa505ad Compare July 21, 2023 05:46
sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit f734fc8 into master Jul 21, 2023
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-859548-replace-table-test branch July 21, 2023 06:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-pbulawa @sfc-gh-pmotacki