Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-857829 Fix username and password requiredness #846

Merged
merged 1 commit into from
Jul 14, 2023
Merged

SNOW-857829 Fix username and password requiredness #846

merged 1 commit into from
Jul 14, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Jul 13, 2023 •
edited
Loading

Description

Fixes #843
Snowflake required username and password in most auth types, even if they don't really needed. Fix enables username and password checking only if they are really required.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner July 13, 2023 07:14
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Jul 13, 2023
Closed
sfc-gh-dheyman
sfc-gh-dheyman reviewed Jul 13, 2023
View reviewed changes
dsn.go Outdated Show resolved Hide resolved
sfc-gh-dheyman
sfc-gh-dheyman reviewed Jul 13, 2023
View reviewed changes
dsn.go Outdated Show resolved Hide resolved
sfc-gh-dheyman
sfc-gh-dheyman reviewed Jul 13, 2023
View reviewed changes
dsn.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-857829-user-password-required branch 2 times, most recently from 8d896cf to 9318870 Compare July 13, 2023 08:12
sfc-gh-pbulawa
sfc-gh-pbulawa reviewed Jul 13, 2023
View reviewed changes
dsn_test.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-857829-user-password-required branch from 9318870 to ec0e0f1 Compare July 13, 2023 08:27
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Jul 13, 2023
View reviewed changes
dsn_test.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-857829-user-password-required branch from ec0e0f1 to faba847 Compare July 13, 2023 08:50
sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit 3623a16 into master Jul 14, 2023
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-857829-user-password-required branch July 14, 2023 05:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dheyman sfc-gh-dheyman sfc-gh-dheyman approved these changes

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AuthTypeTokenAccessor should not require username and password
5 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-pbulawa @sfc-gh-dheyman