Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to enable SnowAlert to run on EKS with IRSA #425

Merged

Conversation

edulop91
Copy link
Contributor

@edulop91 edulop91 commented Aug 12, 2020

Fixes #423.

Was having an issue where running on EKS with IRSA IAM credential source would yield the Can't pickle coroutine error. We figured out this was fixed on aioboto3 >= 8.0.0. Bumped a couple of dependencies to try and get us to aioboto3 >= 8.0.0

pip check with current deps:

snowflake-connector-python 2.2.10 has requirement cryptography<3.0.0,>=2.5.0, but you have cryptography 3.0.
google-auth 1.20.1 has requirement setuptools>=40.3.0, but you have setuptools 39.0.1.
boto3 1.14.20 has requirement botocore<1.18.0,>=1.17.20, but you have botocore 1.15.32.

pip check with old deps:

oscrypto 1.2.1 has requirement asn1crypto>=1.0.0, but you have asn1crypto 0.24.0.
google-auth 1.20.1 has requirement setuptools>=40.3.0, but you have setuptools 39.0.1.
aiobotocore 0.10.4 has requirement botocore<1.12.253,>=1.12.252, but you have botocore 1.12.253.

Have been running python runners/connectors_runner.py "AWS_COLLECT_%%" to verify and everything seems to work fine so far. Are there any other tests you suggest I could run to further verify?

@sfc-gh-afedorov
Copy link
Collaborator

Our automated tests cover the core use cases and they are happy with this change, so lgtm. Will be part of the next release and the snowsec/snowalert:1.9.6-rc branch until then.

@sfc-gh-afedorov sfc-gh-afedorov merged commit 27b0fcc into snowflakedb:v1.9.6 Aug 12, 2020
@edulop91
Copy link
Contributor Author

Perfect, thank you!

@edulop91
Copy link
Contributor Author

Deployed 1.9.6-rc and verified working.

sfc-gh-afedorov pushed a commit that referenced this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants