Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues with how the Slack handler handles errors.
The first is a fix for the Exception message formatting, which resulted in a string concatenation error before, and the raised exception was actually this one, not the original exception. Now it uses string templates properly and raises the intended exception.
The second fix is to let any error with the UDF propagate up to the calling function, instead of returning
None
.Before, catching this exception and returning
None
would result in alert_dispatcher thinking the handler completed successfully; it would setwhere the return value of
apply_some(...)
wasNone
.This fix raises the exception up so that the
result
includessuccess: False
and the exception that caused it.