[DC] Cisco Umbrella Connector #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/connectors/cisco_umbrella.py
Outdated
| ] | ||
|
|
||
|
|
||
| def get_col_transform(idx: int) -> str: |
There was a problem hiding this comment.
Ideally the get_col_transform and related code would be integrated into db.py and then connectors use it from there, so that we're not duplicating code across multiple connectors. I think Eduardo is working on that?
There was a problem hiding this comment.
This code has been merged into db.py; can you pull this part out and use the db.py interface instead?
alldoami
changed the title
alldoami
changed the title
|
Do you have an icon you can add to |
edulop91
force-pushed
the
adoami/cisco_umbrella
branch
from
4dc325c
to
738a744
Compare
added 2 commits
August 26, 2019 14:04
sfc-gh-gbutzi
added a commit
that referenced
this pull request
Sep 4, 2019
* [DC] GitHub Webhook via S3 (#270) * [DC] Okta Connector Enhancement (#282) * [DC] Azure Subscription Connector supports Gov cloud (#281) * [Handlers] SES, SNS, Twilio, Stored Procedure, SMTP (#284) * [DC] Crowdstrike devices via API (#279) * [DC] Add Crowdstrike API Connector * [DC] Crowdstrike Static Analysis (#287) * [DC] Cisco Umbrella Connector (#280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.