Skip to content

Commit

Permalink
[DC] Improves AWS Inventory Connector (#303)
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-gbutzi authored and sfc-gh-afedorov committed Sep 10, 2019
1 parent 0a45d89 commit 72f572c
Show file tree
Hide file tree
Showing 3 changed files with 374 additions and 112 deletions.
24 changes: 22 additions & 2 deletions migrations/v1_8_5-v1_8_6.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
## AWS Accounts Connector

In v1.8.6 the AWS Accounts DC has been adjusted so that the Account ID is represented as a string as opposed to a number. This will necessitate dropping and recreating the connector to get the correct table, which can be done with sql like the snippet below:

> Note: we say "like" below because the sql script will need the correct names of the resources; make sure that you specify the custom name for your connector, if you provided one.

### Removing the AWS Accounts Connector

~~~
DROP TABLE snowalert.data.AWS_ACCOUNTS_DEFAULT_CONNECTION;
~~~

Once the connection table is dropped, you can recreate the connector using the UI.


## Cisco Umbrella Connector

### Landing table name changed

We're renaming the table in a way that specifies that this is an inventory of roaming clients. There's no specific reaon to migrate but if you'd like to keep things tidy, please prepend `cisco_umbrella_` instead of `cisco_` to your landing tables with sql like the following:

### Changing the landing table name for the Cisco Umbrella Connector
~~~
ALTER TABLE snowalert.data.cisco_umbrella_default_connection RENAME TO snowalert.data.cisco_umbrella_devices_default_connection;
~~~

Naming the table in a way that specifies that this is an inventory of roaming clients.
4 changes: 2 additions & 2 deletions src/connectors/aws_accounts.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
('created_at', 'TIMESTAMP_LTZ'),
('arn', 'STRING(100)'),
('email', 'STRING(100)'),
('account_id', 'NUMBER'),
('account_id', 'STRING(25)'),
('joined_method', 'STRING(50)'),
('joined_timestamp', 'TIMESTAMP_LTZ'),
('account_alias', 'STRING(100)'),
Expand Down Expand Up @@ -98,7 +98,7 @@ def ingest(table_name, options):
'column2',
'column3::STRING',
'column4::STRING',
'column5::NUMBER',
'column5::STRING',
'column6::STRING',
'column7::TIMESTAMP_LTZ',
'column8::STRING',
Expand Down
Loading

0 comments on commit 72f572c

Please sign in to comment.