Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black version to fix build #1693

Merged
merged 4 commits into from
Apr 8, 2022
Merged

Update black version to fix build #1693

merged 4 commits into from
Apr 8, 2022

Conversation

fpoms
Copy link
Contributor

@fpoms fpoms commented Apr 8, 2022

Description of proposed changes

Update black version to 22.3>= to fix issue with newer version of Click (pallets/click#2225).
Also modify test_loss.py to change np.testing.assert_equal(ce_loss.numpy(), ces_loss.numpy()) to np.testing.assert_almost_equal(ce_loss.numpy(), ces_loss.numpy()) to deal with newer torch code.

Related issue(s)

Fixes # (issue)

Test plan

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
  • All new and existing tests passed.

@fpoms fpoms requested a review from rsmith49 April 8, 2022 20:03
Copy link
Contributor

@rsmith49 rsmith49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fpoms!

@fpoms fpoms merged commit 85a50f7 into master Apr 8, 2022
@fpoms fpoms deleted the fpoms/update-black branch April 8, 2022 20:06
akode pushed a commit to akode/snorkel that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants