Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating travis -> circle #1685

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Migrating travis -> circle #1685

merged 1 commit into from
Dec 3, 2021

Conversation

humzaiqbal
Copy link
Contributor

@humzaiqbal humzaiqbal commented Dec 2, 2021 •
edited
Loading

Description of proposed changes

Replacing the CI system from Travis to Circle as we have seen issues running on Travis

Related issue(s)

N/A
Fixes # (issue)
N/A

Test plan

Having the CI tests run be Circle instead of Travis should test this

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
  • All new and existing tests passed.

@humzaiqbal humzaiqbal requested a review from henryre December 2, 2021 16:17
henryre
henryre approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@henryre henryre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff 🚀

We'll need to check results of next run against trunk, but fine to do this on the fly.

@henryre henryre merged commit b68db9f into master Dec 3, 2021
@henryre henryre deleted the humzaiqbal/circleci-setup branch December 3, 2021 04:42
akode pushed a commit to akode/snorkel that referenced this pull request Jun 10, 2022
@humzaiqbal
Migrating travis -> circle (snorkel-team#1685)
2cae679 
## Description of proposed changes
Replacing the CI system from Travis to Circle as we have seen issues running on Travis
## Related issue(s)
N/A
Fixes # (issue)
N/A
## Test plan
Having the CI tests run be Circle instead of Travis should test this 
## Checklist

Need help on these? Just ask!

* [x] I have read the **CONTRIBUTING** document.
* [x] I have updated the documentation accordingly.
* [x] I have added tests to cover my changes.
* [x] I have run `tox -e complex` and/or `tox -e spark` if appropriate.
* [x] All new and existing tests passed.
@bhancock8 bhancock8 mentioned this pull request Jul 23, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryre henryre henryre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humzaiqbal @henryre