Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model baseline model imports to snorkel/labeling/model #1535

Merged
merged 3 commits into from
Jan 20, 2020

Conversation

vincentschen
Copy link
Member

@vincentschen vincentschen commented Jan 19, 2020

Description of proposed changes

  • snorkel/labeling/__init__.py contained extraneous imports for baseline models. Cleaning up dependencies by moving model imports to snorkel/labeling/model/__init__.py

Test plan

  • Ran tox + tox -e doc + tox -e complex

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
  • All new and existing tests passed.

@vincentschen vincentschen requested review from henryre and a team January 19, 2020 19:27
@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #1535 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1535   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          55       55           
  Lines        2052     2052           
  Branches      338      338           
=======================================
  Hits         2001     2001           
  Misses         23       23           
  Partials       28       28

Copy link
Member

@henryre henryre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentschen looking good! Need to add model to https://github.com/snorkel-team/snorkel/blob/master/docs/packages.json to generate the doc pages!

@vincentschen
Copy link
Member Author

vincentschen commented Jan 19, 2020

@vincentschen looking good! Need to add model to https://github.com/snorkel-team/snorkel/blob/master/docs/packages.json to generate the doc pages!

Nice catch — Added!

@henryre Also ran tox -e doc afterwards, but no additional chances. Should I expect the underlying _autosummary/.rst files to update?
Fixed with tox -e fix!

@vincentschen vincentschen requested a review from henryre January 19, 2020 23:14
Copy link
Member

@henryre henryre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it!

@vincentschen vincentschen merged commit 4c227a0 into master Jan 20, 2020
@vincentschen vincentschen deleted the clean-labeling-init branch January 20, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants