Rework/1297

[HiromuHota]

Description of proposed changes

This PR upgrade tqdm to >=4.33.0, which is now compatible with pandas==0.25.0

See tqdm/tqdm#780

Related issue(s)

Fixes #1297

Test plan

Checklist

Need help on these? Just ask!

• I have read the CONTRIBUTING document.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• I have run tox -e complex and/or tox -e spark if appropriate.
• All new and existing tests passed.

[henryre]

@HiromuHota awesome, thanks for sorting this out! tqdm is disabled in most of our unit tests, so just as a sanity check, were you able to run a PandasLFApplier using tqdm with these package versions?

[HiromuHota]

@henryre Thanks for your comment.
I quickly did a sanity check using the Spouse tutorial and the progress bar worked.
Below is a console log.

>>> from snorkel.labeling import PandasLFApplier
>>> 
>>> lfs = [
...     lf_husband_wife,
...     lf_husband_wife_left_window,
...     lf_same_last_name,
...     lf_married,
...     lf_familial_relationship,
...     lf_family_left_window,
...     lf_other_relationship,
...     lf_distant_supervision,
...     lf_distant_supervision_last_names,
... ]
>>> applier = PandasLFApplier(lfs)
>>> 
>>> from snorkel.labeling import LFAnalysis
>>> 
>>> L_dev = applier.apply(df_dev)
/Users/hiromu/workspace/snorkel/.env/lib/python3.7/site-packages/tqdm/std.py:648: FutureWarning: The Panel class is removed from pandas. Accessing it from the top-level namespace will also be removed in the next version
  from pandas import Panel
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2811/2811 [00:06<00:00, 451.24it/s]
>>> L_train = applier.apply(df_train)
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 22254/22254 [00:50<00:00, 444.79it/s]
>>> 
>>> 
>>> tqdm.__version__
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'tqdm' is not defined
>>> import tqdm
>>> tqdm.__version__
'4.36.1'
>>> pandas.__version__
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'pandas' is not defined
>>> pd.__version__
'0.25.1'

By the way, I confirmed that the first commit of the two (871dcae) failed the travis on my travis account (https://travis-ci.com/HiromuHota/snorkel/builds/129603857).
Hope this information also helps.

[henryre]

@HiromuHota awesome, then we're good to go here. Thanks again!!

[HiromuHota]

@henryre Thanks for your approval.
CONTRIBUTING.md says

The PR author owns the test plan and has final say on correctness. Therefore, it is up to the PR author to merge their PR.

but I have no write access hence cannot merge this PR. How can I merge it?

[henryre]

@HiromuHota ah that's a good point, I'll update the CONTRIBUTING doc, thanks!