Make preds and probs optional in Scorer.score() #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryre
requested changes
Sep 4, 2019
There was a problem hiding this comment.
@bhancock8 especially now that the inputs can be optional, can we improve the doc string? e.g. "Probabilities (floats)" doesn't tell me anything.
Codecov Report
@@ Coverage Diff @@
## master #1441 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 55 55
Lines 1996 1996
Branches 327 327
=======================================
Hits 1947 1947
Misses 22 22
Partials 27 27
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Make preds and probs optional for Scorer.score(), since it's just a wrapper around individual metric computation calls (usually via
metric_score), and those metrics raise an Exception if they've been passed aNonewhere they expected values. This change removes boilerplate from score() and loses no protection.Related issue(s)
Fixes #1417
Test plan
Add new test confirming that Scorer.score() can be called with or without probs.
Checklist
Need help on these? Just ask!