Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for changes introduced in v1.2.0a1 #33

Merged
merged 2 commits into from
May 22, 2021
Merged

Add support for changes introduced in v1.2.0a1 #33

merged 2 commits into from
May 22, 2021

Conversation

sondrelg
Copy link
Member

@sondrelg sondrelg commented May 21, 2021

Poetry just released 1.2.0a1, here.

From the changes, the most notable for us seems to be that they are deprecating the get-poetry.py script. This PR therefore switches to using the install-poetry.py script instead.

@sondrelg sondrelg force-pushed the v1.2 branch 30 times, most recently from 80ee9c0 to e1f6566 Compare May 21, 2021 20:55
@sondrelg sondrelg force-pushed the v1.2 branch 16 times, most recently from f0e6185 to 6e6adf6 Compare May 21, 2021 22:28
@sondrelg sondrelg marked this pull request as ready for review May 21, 2021 22:43
@sondrelg sondrelg requested a review from JonasKs May 21, 2021 22:43
@sondrelg
Copy link
Member Author

@macbre and @JWCook, since you seem to use the action, feel free to review this if you want to 👏

The more eyes on this the better 🙂

@sondrelg sondrelg changed the title Add support for changes introduced in v1.2 Add support for changes introduced in v1.2.0a1 May 21, 2021
@JWCook
Copy link

JWCook commented May 21, 2021

Looks good to me! Looking over the details on the new install script (python-poetry/poetry#3706), I believe that will fix the issues we were having with installing on python 3.10 (and any future python versions). Related issues:

Copy link
Member

@JonasKs JonasKs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@sondrelg sondrelg merged commit 4315377 into main May 22, 2021
@sondrelg sondrelg deleted the v1.2 branch May 22, 2021 18:07
macbre added a commit to macbre/sql-metadata that referenced this pull request May 22, 2021
macbre added a commit to macbre/sql-metadata that referenced this pull request Oct 18, 2021
* CI - add Python 3.10

* Use 3.10.0-alpha

And actions/setup-python@v2

* Use 3.10.0-alpha.5

* Install Poetry via curl

* Run "source $HOME/.poetry/env"

* Update python-ci.yml

* Make poetry discoverable within $PATH

* pip install cleo

* Try "pip install --user poetry"

* Update python-ci.yml

* sudo ln -s ~/.local/bin/poetry /usr/local/bin/poetry

* Update python-ci.yml

* pip install wheel poetry

* pip install wheel

* Update python-ci.yml

* Update python-ci.yml

* Update python-ci.yml

* Update python-ci.yml

* Update python-ci.yml

* Install poetry via pip

* Add poetry.lock hash to the cache key

* Pre-install black

  EnvCommandError

  Command ['/home/runner/work/sql-metadata/sql-metadata/.venv/bin/pip', 'install', '--no-deps', '/home/runner/.cache/pypoetry/artifacts/64/08/ea/6fcac08da010d65557566f4f78be903d17d7f7ae66e7584e4334a8bb6e/dataclasses-0.8-py3-none-any.whl'] errored with the following return code 1, and output: 
  Processing /home/runner/.cache/pypoetry/artifacts/64/08/ea/6fcac08da010d65557566f4f78be903d17d7f7ae66e7584e4334a8bb6e/dataclasses-0.8-py3-none-any.whl
  ERROR: Package 'dataclasses' requires a different Python: 3.10.0 not in '<3.7,>=3.6'

* pip install poetry==1.1.6

* Update python-ci.yml

snok/install-poetry#33 + snok/install-poetry#35

* 3.10.0-beta.3

* Use Poetry 1.1.7

* Use 3.10.0-beta.4

* 3.10.0-rc.1

* Python 3.10 has just been released!

https://docs.python.org/3/whatsnew/3.10.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants