fix: Fix for Missing Temperature Readings and also a fix for pytest runs and for video streaming #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest now works with the changes to the live stream api changes
changes get_Readings range from 2 hours to 1. The resulting JSON from Canary lists 20 items, the first 12 are air quality, the next 8 are humidity. Temperature is not returned in the first 20 records. I don't know if Canary changed the order in which the data is returned (date-time vs sensor_type) but it appears to be sensor-type, then date desc. This appears to be why temperature is missing. Changing the window of time to look at to 1 hour resulted in all three data types (air_quality, humidify and temperature) to be retuned in the Api.get_readings call.
looks like canary changed the file that sets the ssesyranac cookie from the login page to a manifest.json file linked off the login page. Looking at all the files, that was the only file that set the ssesyranac cookie.
|
get session cookies fix from above allows the library to load up a captured image in my testing... |
0bmay
changed the title
- updates canary's user agent header app version and iOS version - reformat code - adds pre-commit (dev tool) - adds pytest config data
drops the time range to get readings from 1 hour to 40 minutes. This allows to get 5 different reading types instead of 4, due to the 20 record limit returned by canary's API call. Current sensor types are air_quality, humidity, temperature, battery and wifi.
updates pre-commit to run pylint adds pre-commit to requirements_tests.txt
|
Awesome! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how data was returned in the past, but it appears that Canary has changed the number of records returned by Readings API URL or changed the sort order, but on April 30th, 2022 the temperature readings were no longer returned from the get_readings function.
Manually calling the API calls in PAW showed that the readings API call returns 20 records, with the first 12 being air_quality, the next 8 being humidity. Changing the created__range to 1 hour at 10 minute intervals returns 19 records( 1-6 being air quality, 7-12 humidity, 13-18 temperature and 19 being wifi) with all records listed in descending time.
Also fixed is running pytest after Katie made changes for fixing Live Streaming.
Home Assistant issue thread
Temperature is no longer being returned in the get_readings / get_latest_readings call