Update ffi and kotlin bindings #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredszaq
requested changes
Apr 5, 2019
| override fun getFieldOrder() = listOf("intent_name", "confidence_score") | ||
|
|
||
| fun toIntentClassifierResult() = IntentClassifierResult(intentName = intent_name?.readString(), | ||
| confidenceScore = confidence_score!!) | ||
| } | ||
|
|
||
| class CSlots : Structure(), Structure.ByReference { | ||
| class CIntentClassifierResultList(p: Pointer?) : Structure(p), Structure.ByReference { |
There was a problem hiding this comment.
name it CIntentClassifierResults to follow the exisiting convention ? (we use s in nlu ontology and Array in hermes... let's not introduce a new one)
fredszaq
approved these changes
Apr 5, 2019
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CIntentClassifierResultListobjet to the ffi, which is used in theget_intentsAPI ofsnips-nlu-rsPointerwhen creating aCIntentClassifierResultorCSlotsobject