Add converters from C to Rust for ontology objects #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienball
requested changes
Apr 5, 2019
|
Now that you have implemented |
introduces failure library to handle conversion errors.
…s round trip tests
anthonyray
force-pushed
the
task/c_slot_conversion
branch
from
435613a to
22d700c
Compare
adrienball
reviewed
Apr 8, 2019
adrienball
requested changes
Apr 8, 2019
adrienball
approved these changes
Apr 8, 2019
adrienball
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I needed conversion methods for Slots. The conversions from C to Rust object where missing for Slot objects.
I also took the initiative to introduce the very practical trait :
AsRust, and thus diverge from implementing theFromtrait.I also took the liberty to introduce
failureas a dependency, so that we are consistent across crates.Let me know if I need to fix somethin.