Prevent from injecting empty values #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienball
requested changes
Sep 30, 2019
|
|
||
| if tokens.len() == 0 { | ||
| bail!("Can't add value '{}' because it's empty or contains only whitespaces.", entity_value.raw_value) | ||
| } |
There was a problem hiding this comment.
It would be more efficient to use a boolean flag is_empty and set it to true in the loop. It will avoid creating a vector, and will make injection slightly faster.
There was a problem hiding this comment.
Another detail is that the resolved_symbol_table should not be updated in case of invalid input.
ClemDoum
force-pushed
the
fix/empty-values
branch
from
29d6366 to
7adda02
Compare
adrienball
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the user to inject empty values. By empty we mean values that contain no characters or only whitespaces.
This was previously allowed and made the injection from vanilla crash when trying to inject after injecting an empty character:
tokens_symbol_table,token_to_resolved_valuesandresolved_value_to_tokenswhere not updated with any token.resolved_symbol_tablebut then when trying to get the tokens of the resolved value withget_tokens_from_resolved_valuein order to remove them from thetokens_symbol_table,token_to_resolved_valuesandresolved_value_to_tokensmaps, we can't find any token for the given resolved value since we didn't insert any