Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16097 - added location ID to location importer #16099

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jan 20, 2025

This allows you to include an ID in the location importer to update by ID instead of name. Fixes #16097

Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Jan 20, 2025

PR Summary

  • DefaultFieldMap Updates in Importer.php
    The mapping within the Importer.php file has been updated to include 'id', this will allow better identification and data management within the system.

  • Refined Location Retrieval Logic in LocationImporter.php
    The method for finding a location within the system has been modified. It will now prioritize searching for a location by using the 'id' before resorting to the 'name'. This should increase the efficiency of location searches within the system.

  • Added 'id' Field Translation in Importer.php
    An 'id' field translation has been introduced in Importer.php under $this->locations_fields. This would enhance multiple language support, making the platform more user-friendly across different regions or users with differing language preferences.

snipe added 4 commits January 20, 2025 16:38
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 5afcd8d into develop Jan 20, 2025
9 checks passed
@snipe snipe deleted the add_id_to_locations_importer branch January 20, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant