Fixed acceptance reminder email formatting #16035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting the "Re-send Reminder" button on the Unaccepted Assets page (
/reports/unaccepted_assets
) the email that is sent isn't formatted correctly. This PR fixes that.The keys are squished:
![](https://private-user-images.githubusercontent.com/1141514/400901118-baaacfa6-726f-4c49-997c-0ac6ce03df68.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTI2NDMsIm5iZiI6MTczOTI1MjM0MywicGF0aCI6Ii8xMTQxNTE0LzQwMDkwMTExOC1iYWFhY2ZhNi03MjZmLTRjNDktOTk3Yy0wYWM2Y2UwM2RmNjgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMDUzOTAzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTU0OWI1M2E0MGE1NGY4MzBjMzMxOTdmMTAzMWVlNzdmNzJhOTc5ZTVhYzc3NWU0MTcyNGYyOGFiODE2YTNhMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.G9oEkcUfm1Ut4iVDVWUKsdeSmoqzE3fB8B2UzqJI-X4)
This is due to the "notes" actually being set to the acceptance itself.
![](https://private-user-images.githubusercontent.com/1141514/400901196-458c39ec-c729-4869-9581-41cee4641782.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTI2NDMsIm5iZiI6MTczOTI1MjM0MywicGF0aCI6Ii8xMTQxNTE0LzQwMDkwMTE5Ni00NThjMzllYy1jNzI5LTQ4NjktOTU4MS00MWNlZTQ2NDE3ODIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMDUzOTAzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDAwNmNmMmI0ZGI4ZjNkNjRkYjIwYmY2OGQ5MDRmM2EwODdhYWYwYzA0YzQ4MDRjNDVkN2U1YzBkM2ZjMmE5ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.SeZUxMh51fXllnpfmnyTcSziIaRd9Gjn0inseEKGMRQ)
By fixing the parameter order we fix the issue:
![](https://private-user-images.githubusercontent.com/1141514/400901241-c25e8dbb-e518-46e8-a741-e9a6d447aa9c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTI2NDMsIm5iZiI6MTczOTI1MjM0MywicGF0aCI6Ii8xMTQxNTE0LzQwMDkwMTI0MS1jMjVlOGRiYi1lNTE4LTQ2ZTgtYTc0MS1lOWE2ZDQ0N2FhOWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMDUzOTAzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MWFlYjY0NTlkMTE3MzI3Y2M1ZmI4MDRhYWE5MTNiNGI1MGJlNjBiYWY5ZGM4NjNiZTRmNjMzYWQ3YWVkNzk2NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.b9eTRy18ZYlSsWuNlnsJPnPCwg80h4IASykRBDWb6Vg)